Update k8s api compatibility #2267
Conversation
|
Thank you for this. We are still struggling a bit with CI. We'll review it as soon as it's fixed |
|
run k8s-tests |
Dockerfile
Outdated
| @@ -0,0 +1,20 @@ | |||
| ARG BASE=ubuntu:19.10 | |||
There was a problem hiding this comment.
The "official" Dockerfile is in contrib/docker and can be built using make docker-image (.mk/dist.mk)
There was a problem hiding this comment.
you're right, my aim was to launch the build process inside a temporary container to avoid being dependent from libs on the host where it is run (cf. "build" level of the PR's Dockerfile) and also avoid copying sources in a dir below (as
Line 51 in 3bd6c51
There was a problem hiding this comment.
No problem. We have such a Dockerfile in the repository of our CI scripts : https://github.com/skydive-project/skydive-ci/blob/master/scripts/Dockerfile.compile
We have now fixed most of the CI issues. Could you please rebase your PR on top of master, without the Dockerfile ? Thanks a lot !
lebauce
force-pushed
the
update_k8s_api_compatibility
branch
from
3ae976d
to
8ad74dd
Compare
|
Thanks! No time to finalize MR on my side currently. |
|
@LoicLeGal No problem :-) |
Fixes #2169, #2251 and also complement the Helm Chart fix of skydive-project/skydive-helm/issues/2